Closed
Conversation
Member
|
This seems fine to me, though I'm unable to test this myself. |
Member
|
bumping distro version requires students to upgrade their LLVM version; this is better done at the beginning of the semester :( |
connortsui20
added
the
deferred
Author
This change doesn't force anyone to have to update their dev environment. It's simply a QOL change for those who run the latest version of Ubuntu. |
Member
|
Fixed in #827 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny change to support current Ubuntu LTS. I tried to follow the established pattern here, but do we actually care about which version of Ubuntu is running? In the case of
DARWINwe're not checking the OS version.If the concern is to use the appropriate package manager then instead of
VERSIONtheNAMEvariable could be pattern matched against: